Add toggle for debug settings #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
|
View Playwright Report (note: open the "playwright-report" artifact) |
|
Is it possible to group the debug settings together so that we don't have one debug setting sitting among other types (like in the screenshot) |
Casheeew
approved these changes
Jul 29, 2024
Kindof... For settings that are normal items in the settings page this is fine. But for settings that are integrated into other settings modals theres no way to do this. I think it's fine for that to be handled in another pr though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base settings are reasonably chosen and only includes basic settings as is expected.
The advanced settings however, include both advanced settings as well as some settings that we should not expect even advanced users to use. These types of settings should not be considered "Advanced settings" and should be split out entirely.
Ive created "Debug settings" for this and only things that should almost never be touched by users should be included here. This toggle is only shown when advanced settings are enabled. Possibly this toggle shouldnt even be on the settings page and could be hidden away even further on the info page or something but I think it looks reasonable as I have it here.
The settings Ive put under debug for now isnt anything definitive. Theres probably more but just a super quick look these seem like obvious candidates.
Toggle:
Debug setting highlight:
