Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "Search text with non-Japanese characters" when language is not Japanese #1247

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Hide "Search text with non-Japanese characters" when language is not Japanese #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/css/settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,9 @@ a.heading-link-light {
:root:not([data-advanced=false]) .basic-only {
display: none;
}
:root:not([data-language=ja]) .japanese-only {
display: none;
}
.settings-item.settings-item-button,
a.settings-item.settings-item-button {
cursor: pointer;
Expand Down
11 changes: 9 additions & 2 deletions ext/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ <h1>Yomitan Settings</h1>
</div>
</div>
<div class="settings-item-right">
<select id="language-select" data-setting="general.language"></select>
<select id="language-select" data-setting="general.language"
data-transform='{
"type": "setAttribute",
"selector": ":root",
"attribute": "data-language"
}'
></select>
</div>
</div></div>
<div class="settings-item"><div class="settings-item-inner">
Expand Down Expand Up @@ -389,9 +395,10 @@ <h1>Yomitan Settings</h1>
<label class="toggle"><input type="checkbox" data-setting="scanning.selectText"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
</div>
</div></div>
<div class="settings-item"><div class="settings-item-inner">
<div class="settings-item japanese-only"><div class="settings-item-inner">
<div class="settings-item-left">
<div class="settings-item-label">Search text with non-Japanese characters</div>
<div class="settings-item-description">Only applies when language is set to Japanese.</div>
</div>
<div class="settings-item-right">
<label class="toggle"><input type="checkbox" data-setting="scanning.alphanumeric"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
Expand Down