Fix Firefox scanning when some combining characters are present #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
|
Why was it removed previously? |
Casheeew
previously approved these changes
Jul 13, 2024
The issues it had with japanese were not present anymore. I've made it so this only applies to Thai now as that's only one we have reported and we probably do want this check to stay for the languages it works fine on. If needed more languages can be added to the exclude list. |
Casheeew
approved these changes
Jul 13, 2024
StefanVukovic99
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox's implementation of
Range.getClientRects()does not match Chromium when text contains certain unicode combining characters and cannot be relied upon.Fun 12 year old bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=816238
This was previously handled in Yomichan but 5 years ago it was removed in ea9c5ad. Japanese text and Japanese combining characters do not have this issue but some other languages do.
Fixes #1002