Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tl] Add diacritics removal preprocessors #1213

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

Casheeew
Copy link
Collaborator

@Casheeew Casheeew commented Jul 13, 2024

Normal everyday Tagalog does not use diacritics, so Yomitan fails to find any match for words which has diacritics in the dictionary. According to https://en.wikibooks.org/wiki/Tagalog/Lesson_13:

Diacritics are normally not written in everyday usage, be it in publications or personal correspondence. The teaching of diacritics is inconsistent in Filipino schools and many Filipinos do not know how to use them. However, diacritics are normally used in dictionaries and in textbooks aimed at teaching the languages to foreigners.

image

Needs to be followed by diacritics removal at the dictionary level (e.g at KTY)

@Casheeew Casheeew requested a review from a team as a code owner July 13, 2024 01:35
@StefanVukovic99 StefanVukovic99 added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Jul 13, 2024
@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Jul 13, 2024
Merged via the queue into themoeway:master with commit 3823c82 Jul 13, 2024
10 checks passed
@Casheeew Casheeew deleted the tl-diacritics-removal branch July 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants