Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font Customization Options #1184

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Jul 8, 2024

msedge_Yomitan_Settings_and_6_more_pages_-Dev-_Microsof_2024-07-07_21-18-52

Font size and line height here are both advanced settings.

Resolves #1077

@MarvNC MarvNC requested a review from a team as a code owner July 8, 2024 04:20
Copy link

github-actions bot commented Jul 8, 2024

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@MarvNC
Copy link
Member Author

MarvNC commented Jul 8, 2024

Visual differences are due to the line height not being exactly the same (it was 20/14 before, I elected to set it to 1.5 as the default)

@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Jul 10, 2024
Merged via the queue into yomidevs:master with commit e338257 Jul 10, 2024
11 checks passed
@MarvNC MarvNC deleted the add-font-options branch July 12, 2024 08:04
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dedicated Font Setting
3 participants