forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Font Customization Options #1184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Playwright Report (note: open the "playwright-report" artifact) |
Visual differences are due to the line height not being exactly the same (it was 20/14 before, I elected to set it to 1.5 as the default) |
StefanVukovic99
previously approved these changes
Jul 10, 2024
StefanVukovic99
approved these changes
Jul 10, 2024
Kuuuube
added
kind/enhancement
The issue or PR is a new feature or request
area/ui-ux
The issue or PR is related to UI/UX/Design
labels
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ui-ux
The issue or PR is related to UI/UX/Design
kind/enhancement
The issue or PR is a new feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font size and line height here are both advanced settings.
Resolves #1077