Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with font on Cyrillic dictionaries #1259

Closed
YukiNagat0 opened this issue Jul 22, 2024 · 2 comments
Closed

Problems with font on Cyrillic dictionaries #1259

YukiNagat0 opened this issue Jul 22, 2024 · 2 comments
Labels
kind/bug The issue or PR is regarding a bug

Comments

@YukiNagat0
Copy link

YukiNagat0 commented Jul 22, 2024

Description
After update, on default font (void or "sans-serif") cyrillic dictionaries went crazy. Before addition of Font customization (#1184) entries were displayed correctly.
Cyrillic

Proposal:

  1. Return prior default font
  2. Add an option to change font of the specific dictionary (e.g. set a global/base font for all dictionaries and set a different font for the specific dictionaries as exception)

For more context: https://discord.com/channels/617136488840429598/1081538711742844980/1265006180028387400

Browser version
Chrome 126.0.6478.183 (64-bit)

Yomitan version
Yomitan 24.7.15.0

@YukiNagat0 YukiNagat0 added the kind/bug The issue or PR is regarding a bug label Jul 22, 2024
@YukiNagat0 YukiNagat0 changed the title Font problems with Cyrillic dictionaries Problems with font on Cyrillic dictionaries Jul 22, 2024
@MarvNC
Copy link
Member

MarvNC commented Jul 22, 2024

Reproduced on the 7.15 release, it appears to be fixed in the 7.22 development release likely due to #1231.

Having an empty string as the font (in releases after 7.15) should be the same as before the font option was added (the font will be 'Helvetica Neue', Helvetica, Arial, sans-serif).

@YukiNagat0
Copy link
Author

Fixed in 24.7.24.0 (stable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

2 participants