Hide "Search text with non-Japanese characters" when language is not …

…Japanese (#1247)
themoeway · Jul 20, 2024 · 77b184a · 77b184a
1 parent f6bafa5
commit 77b184a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/ext/css/settings.css b/ext/css/settings.css
@@ -644,6 +644,9 @@ a.heading-link-light {
 :root:not([data-advanced=false]) .basic-only {
     display: none;
 }
+:root:not([data-language=ja]) .japanese-only {
+    display: none;
+}
 .settings-item.settings-item-button,
 a.settings-item.settings-item-button {
     cursor: pointer;

diff --git a/ext/settings.html b/ext/settings.html
@@ -137,7 +137,13 @@ <h1>Yomitan Settings</h1>
                     </div>
                 </div>
                 <div class="settings-item-right">
-                    <select id="language-select" data-setting="general.language"></select>
+                    <select id="language-select" data-setting="general.language"
+                    data-transform='{
+                        "type": "setAttribute",
+                        "selector": ":root",
+                        "attribute": "data-language"
+                    }'
+                    ></select>
                 </div>
             </div></div>
             <div class="settings-item"><div class="settings-item-inner">
@@ -389,9 +395,10 @@ <h1>Yomitan Settings</h1>
                 <label class="toggle"><input type="checkbox" data-setting="scanning.selectText"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
             </div>
         </div></div>
-        <div class="settings-item"><div class="settings-item-inner">
+        <div class="settings-item japanese-only"><div class="settings-item-inner">
             <div class="settings-item-left">
                 <div class="settings-item-label">Search text with non-Japanese characters</div>
+                <div class="settings-item-description">Only applies when language is set to Japanese.</div>
             </div>
             <div class="settings-item-right">
                 <label class="toggle"><input type="checkbox" data-setting="scanning.alphanumeric"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>