Add eslint rule no-restricted-syntax (#486)

themoeway · Dec 29, 2023 · 42c3b0d · 42c3b0d
1 parent 59961b6
commit 42c3b0d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -200,6 +200,17 @@
         ],
         "no-implicit-globals": "error",
         "no-multi-spaces": "error",
+        "no-restricted-syntax": [
+            "error",
+            {
+                "message": "Avoid using JSON.parse(), prefer parseJson.",
+                "selector": "MemberExpression[object.name=JSON][property.name=parse]"
+            },
+            {
+                "message": "Avoid using Response.json(), prefer readResponseJson.",
+                "selector": "MemberExpression[property.name=json]"
+            }
+        ],
         "no-trailing-spaces": "error",
         "no-whitespace-before-property": "error",
         "object-curly-spacing": [

diff --git a/ext/js/core/json.js b/ext/js/core/json.js
@@ -25,6 +25,7 @@
  * @returns {T}
  */
 export function parseJson(value) {
+    // eslint-disable-next-line no-restricted-syntax
     return JSON.parse(value);
 }
 
@@ -36,5 +37,6 @@ export function parseJson(value) {
  * @returns {Promise<T>}
  */
 export async function readResponseJson(response) {
+    // eslint-disable-next-line no-restricted-syntax
     return await response.json();
 }