Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fonts not displayed as active in the font list after saving #1110

Closed
hellor0bot opened this issue Sep 7, 2016 · 9 comments
Closed

Comments

@hellor0bot
Copy link

hellor0bot commented Sep 7, 2016

Issue description:

I've added Custom Fonts like here: #1082

However after saving and reloading the Customizer, the fields are blank:

chrome_2016-09-07_11-40-24

The new fonts are simply not displayed as active in the font list, though they're working fine.

Version used:

develop branch

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

same, as here: #1082

@hellor0bot
Copy link
Author

I've just tested it futher and found out that the same issue is valid for all standard fonts, not only custom ones.

If we select Serif / Sans Serif / Monospace, etc, the font will be saved, but won't be displayed as active after page reload.

@hellor0bot
Copy link
Author

OK, this is caused by different values in label and stack.

If we set both to the same values, the issue's gone. Hope, it won't be hard to fix the issue.

Many thanks!

@imthat
Copy link

imthat commented Mar 7, 2017

It's not working by setting label and stack to the same value.

@djwd
Copy link

djwd commented Mar 11, 2017

@imthat @hellor0bot
same here, can't set a custom font as active font or as default. Setting same value didn't help. Any insight on this please?

@imthat
Copy link

imthat commented Mar 11, 2017

I end up adding the custom fonts directly to get_standard_fonts() function in class-kirki-fonts.php. kirki/fonts/standard_fonts filter somehow does not work properly.

@djwd
Copy link

djwd commented Mar 11, 2017

Thank you @imthat
Problem is that also happens for standard fonts to me, selecting Monospace for e.g. presents the same issue, so adding it directly in get_standard_fonts() function doesn't fix it for me. Doesn't happen for you ?

@djwd
Copy link

djwd commented Mar 11, 2017

I got the issue by reading #873.

The problem is with the default field, value must match the full stack field

@imthat
Copy link

imthat commented Mar 11, 2017

For me Sans-serif font works fine. Serif and Monospace need to use the same label and stack name in order for them to work.

@aristath
Copy link
Contributor

Fixed.
It was a quotes/doublequotes issue 👍

aristath added a commit that referenced this issue May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants