Simplified Variables

[edirpedro]

The variables attribute could have a simplified version for those outputs using a single variable and returning non formatted values, instead of writing that long array format. What do you think?

Kirki::add_field( 'my_config', array(
    'settings'  => 'my_setting',
    'label'     => __( 'Font Size', 'translation_domain' ),
    'section'   => 'my_section',
    'type'      => 'number',
    'priority'  => 10,
    'default'   => '16',
    'variables' => 'mainmenu-font-size'
) );

The get_variables() function:

/**
 * Build the variables.
 *
 * @return array    ('variable-name' => value)
 */
public function get_variables() {

    $variables = array();

    // Loop through all fields.
    foreach ( Kirki::$fields as $field ) {

        // Check if we have variables for this field.
        if ( isset( $field['variables'] ) && $field['variables'] && ! empty( $field['variables'] ) ) {

            // Single variable.
            if ( is_string( $field['variables'] ) ) {

                // Sanitize the variable name.
                $variable_name = esc_attr( $field['variables'] );

                // Get the value.
                $variables[ $variable_name ] = Kirki::get_option( $field['settings'] );

            } else {

                // Loop through the array of variables.
                foreach ( $field['variables'] as $field_variable ) {

                    // Is the variable ['name'] defined? If yes, then we can proceed.
                    if ( isset( $field_variable['name'] ) ) {

                        // Sanitize the variable name.
                        $variable_name = esc_attr( $field_variable['name'] );

                        // Do we have a callback function defined? If not then set $variable_callback to false.
                        $variable_callback = ( isset( $field_variable['callback'] ) && is_callable( $field_variable['callback'] ) ) ? $field_variable['callback'] : false;

                        // If we have a variable_callback defined then get the value of the option
                        // and run it through the callback function.
                        // If no callback is defined (false) then just get the value.
                        if ( $variable_callback ) {
                            $variables[ $variable_name ] = call_user_func( $field_variable['callback'], Kirki::get_option( $field['settings'] ) );
                        } else {
                            $variables[ $variable_name ] = Kirki::get_option( $field['settings'] );
                        }
                    }
                }

            }
        }
    }

    // Pass the variables through a filter ('kirki/variable') and return the array of variables.
    return apply_filters( 'kirki/variable', $variables );

}

[aristath]

Hey there!
I just added a couple of lines to allow using a string.
Can you please pull the latest develop branch and test if that works for you?
Thanks!

[edirpedro]

Hi,
It's not working, this function is receiving the default empty array. I didn't tested my proposal, sorry about that.

[aristath]

Can you please pull again and test it? I just pushed another commit. :)

[edirpedro]

It's working now! :-)