fix: check activateClickOutside on outside click #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleClickOutside checks the state of activateClickOutside when called. This allows setting activateClickOutside when the component is mounted.
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shinokada
pushed a commit
that referenced
this pull request
Sep 22, 2023
handleClickOutside checks the state of activateClickOutside when called. This allows setting activateClickOutside when the component is mounted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1080
📑 Description
This PR introduces a check in the Drawer component which allows changing the value of
activateClickOutsideafter the component is mounted.This is done by adding
activateClickOutsideas a condition inside the function called byclickOutsideWrapper.Status
✅ Checks
I have updated the documentation as requiredℹ Additional Information
This fix assumes that the behaviour is not intentional.