Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use createPortal to render modals #77

Merged
merged 1 commit into from
May 2, 2022
Merged

Use createPortal to render modals #77

merged 1 commit into from
May 2, 2022

Conversation

bacali95
Copy link
Collaborator

@bacali95 bacali95 commented May 2, 2022

Closes #75

@bacali95 bacali95 self-assigned this May 2, 2022
@bacali95 bacali95 requested a review from rluders May 2, 2022 06:38
rluders
rluders approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rluders rluders merged commit e5e5e2e into main May 2, 2022
@rluders rluders deleted the fix/fix-modal-rendering branch May 2, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

Assignees

@bacali95 bacali95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default modal in position:fixed element didn't cover full screen
2 participants
@bacali95 @rluders