Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cypress): fixes cypress e2e test pipeline #695

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

ovichowdhury
Copy link
Contributor

Description

cypress:run script was arising error (Cypress version 10.0.0 no longer supports cypress.json.). So cypress v12.7.0 has been configured as per documentation. And some configuration changes added in tsconfig.json so that cypress e2e and vitest unit tests can be run side by side.

Fixes #694

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Successfully executed all the unit tests in my development environment. yarn cypress:run command is working and running all e2e tests in cypress -> e2e folder.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1fa7542) 99.42% compared to head (6adaae3) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6480     6480           
  Branches      485      485           
=======================================
  Hits         6443     6443           
  Misses         37       37           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders changed the title fix: cypress:run command does not work as expected and the cypress e2e test pipeline is broken chore(cypress): fixes cypress e2e test pipeline Apr 17, 2023
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ovichowdhury

@rluders rluders merged commit ff52bb4 into themesberg:main Apr 17, 2023
@ovichowdhury ovichowdhury deleted the fix/cypress-scripts branch April 18, 2023 07:41
@tulup-conner
Copy link
Collaborator

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cypress:run command does not work as expected and the cypress e2e test pipeline is broken
3 participants