Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add tests for alert component #549

Merged

Conversation

emilcheva
Copy link
Contributor

@emilcheva emilcheva commented Jan 19, 2023

Description

Adds tests for theAlert component.
Fixes typo in the documentation pages (the default color for Alert is 'info', not 'primary'). In fact 'primary' does not exists in the FlowbiteColors -> Pick<FlowbiteColors, 'failure' | 'gray' | 'info' | 'success' | 'warning'>

Related to #500

Type of change

Please delete options that are not relevant.

  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Test Configuration:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 99.29% // Head: 99.29% // No change to project coverage 👍

Coverage data is based on head (dd6fbfe) compared to base (5f01946).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         131      131           
  Lines        5775     5775           
  Branches      480      480           
=======================================
  Hits         5734     5734           
  Misses         41       41           
Impacted Files Coverage Δ
src/lib/components/Alert/Alert.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@rluders rluders merged commit a62e84f into themesberg:main Jan 19, 2023
@emilcheva emilcheva deleted the feat(theme)/add-tests-alert-theme-prop branch January 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants