Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vert tabs #1384

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dhavalveera
Copy link
Contributor

@dhavalveera dhavalveera commented Apr 30, 2024

Hello Maintainers,

this PR adds the missing Vertical Tab Component to the Tabs Components and extends the Tabs components.

A Note over here is to make the Vertical Tab Working, I've added an extra attribute to the code which is data-tab-style="vertical" where the vertical will be passed based on the style props we're receiving from the User for type of Tabs they wants to use, and using that selector in the theme.ts I have made the Vertical Tab working without affecting or breaking the existing one.

Furthermore, @SutuSebastian I would suggest & recommend to rename the style to something else like variant in order to allow the user to select the type of Tabs they're interested to use, this way we can allow the user to select the Tab variant, as well as they can able to use the style={{ }} to use the CSS and avoid the confusion as well.

Summary by CodeRabbit

  • New Features

    • Introduced vertical tabs functionality, allowing tabs to be displayed vertically on the left side of the page.
    • Added examples and documentation for vertical tabs, including various tab states such as active and disabled.
    • Updated UI component styles to support vertical tab layouts.
  • Documentation

    • Added a new section on vertical tabs in the documentation with an example and usage guidelines.
  • Style

    • Enhanced styling options for vertical tabs, including modifications for active and inactive states in different screen sizes.

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 26c414e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 30, 2024

Walkthrough

The update brings vertical tabs functionality to various components and files in the project, enhancing UI flexibility with new styles, properties, and examples for vertical tab alignment.

Changes

Files Changes
.../tabs.mdx, .../tabs/index.ts, .../tabs/tabs.vertical.tsx Introduced vertical tabs with examples and export adjustments.
.../Tabs/Tabs.stories.tsx, .../Tabs/Tabs.tsx, .../Tabs/theme.ts Added vertical style properties and updated component configurations for vertical tabs.

Possibly related issues

🐰✨
Oh hooray! What a day! Tabs go up and down,
In a vertical fray, they now wear a crown.
With a hop and a skip, in the code they lay,
Making UIs flip in a new fancy way!
🌟🐾


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3d0fba5 and 26c414e.
Files selected for processing (1)
  • apps/web/examples/tabs/tabs.vertical.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/examples/tabs/tabs.vertical.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:54am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:54am

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (3)
apps/web/examples/tabs/tabs.vertical.tsx (1)

11-27: Check for potential accessibility improvements.

It's good practice to ensure that interactive elements like tabs have appropriate ARIA roles and properties. Verify that the Tabs and Tabs.Item components are properly using ARIA attributes to enhance accessibility.

apps/web/content/docs/components/tabs.mdx (2)

Line range hint 6-6: Improve clarity in documentation.

Consider simplifying the phrase "inside of the main tabs component" to "inside the main tabs component" for better readability.


Line range hint 18-18: Enhance readability by adding necessary spaces and commas.

Add a space after the code block and before the "## Default tabs" heading. Also, consider using commas before 'and' in complex sentences to improve clarity.

- ...e-react"; ```  ## Default tabs  Add the `<Tabs.Item>` child component to the `<Tabs>` compo...
+ ...e-react"; ```
+
+ ## Default tabs
+
+ Add the `<Tabs.Item>` child component to the `<Tabs>` component, and you can add any type of markup and React components inside of it, and it will be shown when clicking on the associated tab item.

apps/web/examples/tabs/tabs.vertical.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant