Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React warning in ButtonGroup #1323

Merged

Commits on Mar 29, 2024

  1. Fix React warning in ButtonGroup

    This change fixes the following issue:
    
    ButtonGroup was adding positionInGroup to all children rather than just Buttons.  For example, in the following, both the Buttons and the child spans get positionInGroup props:
    
    ```
    <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group>
    ```
    
    This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...”
    
    The review comment in the original code change causing this hints at this issue as well:
    
    themesberg#1273 (comment)
    chunkerchunker authored and SutuSebastian committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ca4f841 View commit details
    Browse the repository at this point in the history
  2. fix formatting

    chunkerchunker authored and SutuSebastian committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    728aa5a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Configuration menu
    Copy the full SHA
    8f1b296 View commit details
    Browse the repository at this point in the history