Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): modal overflowing bottom in chrome on ios #1270

Merged

Conversation

DaniloSI
Copy link
Contributor

Modal overflowing the bottom in chrome on ios due to not using dynamic viewport units.

I fixed this problem in my personal project by changing the inner prop of modal's theme. This answer helped me.

Current Fixed
IMG_3639 IMG_3638

Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 1:13pm

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (7461173) to head (b454afb).
Report is 199 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   99.54%   95.51%   -4.04%     
==========================================
  Files         163      217      +54     
  Lines        6621     9633    +3012     
  Branches      401      554     +153     
==========================================
+ Hits         6591     9201    +2610     
- Misses         30      432     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniloSI DaniloSI changed the title fix(modal]): modal overflowing bottom in chrome on ios fix(modal): modal overflowing bottom in chrome on ios Feb 14, 2024
@DaniloSI DaniloSI force-pushed the fix/modal-overflowing-the-bottom branch from bb153ce to c5d0a53 Compare March 7, 2024 11:14
Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

modal overflowing the bottom in chrome on ios due to not using dynamic viewport units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants