Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): Fixed Typescript error when using Next.js Link in the button as prop #1244

Merged
merged 4 commits into from
Jan 24, 2024
Merged

fix(button): Fixed Typescript error when using Next.js Link in the button as prop #1244

merged 4 commits into from
Jan 24, 2024

Commits on Jan 23, 2024

  1. fix(button): correctly infer type from as prop 

    `as` prop was throwing TS errors when using Next Link component. Now this correctly infers the type
from any component passed to the `as` prop

fix themesberg#1002 fix themesberg#1107
    @nigellima
    nigellima committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    38bd24f View commit details
    Browse the repository at this point in the history

  2. fix(dropdown-item): applied the generic types to DropdownItem and als… 

    …o wraps it with a forwardRef
    @nigellima
    nigellima committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c0dffc6 View commit details
    Browse the repository at this point in the history

  3. docs(button): removed now-unnecessary @ts-expect-error comments

    @nigellima
    nigellima committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    861a937 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. fix(button): replaced use of old genericForwardRef

    @nigellima
    nigellima committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3c8b062 View commit details
    Browse the repository at this point in the history