-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support colors in Avatar component #409
Comments
Line 8: Line 17, before closing the object: Line 19, after closing the object and before
Line 35 or somewhere before Line 62: |
Line 89, before closing the object on line 90: |
Line 100, after closing the object on line 99:
I've personally chose these colours, but this can be changed. |
Adds color property to Avatar component to change image ring color. Works only if border property is true. Adds 'color' test case to the Avatar`s Theme test case themesberg#409
@rluders @tiagossa1 just did PR. @tiagossa1 thank you for the detailed description and steps, it was a really helpful. I've used pallet that was suggested by @tiagossa1 Also I'm going to update docs for Avatar component as well soon. |
Adds 5 examples of rounded and bordered avatars and 5 examples of bordered avatars for Avatar component themesberg#409
* feat(avatar): adds color prop and test case for it Adds color property to Avatar component to change image ring color. Works only if border property is true. Adds 'color' test case to the Avatar`s Theme test case #409 * docs(avatar): adds doc example for avatar color prop Adds 5 examples of rounded and bordered avatars and 5 examples of bordered avatars for Avatar component #409
@sldk-yuri you're welcome! I was checking the original code and almost made it work, so I thought that this was the way to go! Great job! |
Avatar component has color property, but it doesn't work. Any color that is passed doesn't change anything.
IMO, it should have the following colours:
Gray, info and light, if all added, should have different tones, to distinguish them.
I've tried to implemented and almost got it to work, so I think whoever picks this should:
default.ts
and add color styling on 'avatar' key value (see snippets below)Avatar.tsx
must extends from Omit instead of PropsWithChildren and have 'color' argument passed. It should have another prop calledcolor
with a custom interface that explicit tells the colour options. Addtheme.color[color]
at least on the placeholder HTML element.FlowbiteTheme.ts
on avatar key.The text was updated successfully, but these errors were encountered: