Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default footer component for React is not responsive #1085

Closed
Haarolean opened this issue Oct 16, 2023 · 2 comments · Fixed by #1325
Closed

Default footer component for React is not responsive #1085

Haarolean opened this issue Oct 16, 2023 · 2 comments · Fixed by #1325
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers

Comments

@Haarolean
Copy link

Hi,

I've noticed that the default footer component doesn't seem to be responsive, unlike the non-react counterpart.

react component here:
image
non-react from here:
image

Hope the provided information is sufficient. Thanks!
@zoltanszogyenyi zoltanszogyenyi transferred this issue from themesberg/flowbite Oct 24, 2023
@rluders rluders added 🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers labels Nov 21, 2023
rajatpandey441 added a commit to rajatpandey441/flowbite-react that referenced this issue Nov 26, 2023
@rajatpandey441
fix(footer>theme.ts): adding margin to right in footer links
85e5ac2 
The link elements were not responsive because there was no default margin set. me-4 was added to
non-react footer but not in react footer.

themesberg#1085
@rajatpandey441 rajatpandey441 mentioned this issue Nov 26, 2023
Closed
1 task
@rajatpandey441
Copy link
Contributor

@rluders: Merged the fix for this bug.

rajatpandey441 added a commit to rajatpandey441/flowbite-react that referenced this issue Nov 26, 2023
@rajatpandey441
fix(footer>theme.ts): adding margin to right in footer links
e9f416c 
The link elements were not responsive because there was no default margin set. me-4 was added to

themesberg#1085
@rajatpandey441 rajatpandey441 mentioned this issue Nov 26, 2023
Merged
1 task
rajatpandey441 added a commit to rajatpandey441/flowbite-react that referenced this issue Nov 26, 2023
@rajatpandey441
fix(footer>theme.ts): adding margin to right in footer links
9dbca85 
The link elements were not responsive because there was no default margin set. me-4 was added to

themesberg#1085
tulup-conner pushed a commit that referenced this issue Nov 27, 2023
@rajatpandey441
fix(footer>theme.ts): adding margin to right in footer links (#1153)
7c1275e 
The link elements were not responsive because there was no default margin set. me-4 was added to

#1085
@Haarolean
Copy link
Author

@rajatpandey441 thank you!

@github-actions github-actions bot mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages themesberg/flowbite-react
4 participants
@rluders @Haarolean @rajatpandey441 @SutuSebastian