Use Object.assign instead of lodash merge

[stevenjoezhang]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines.
• Tests for the changes was maked (for bug fixes / features).
  • Muse | Mist have been tested.
  • Pisces | Gemini have been tested.
• Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

• Bugfix.
• Feature.
• Code style update (formatting, local variables).
• Refactoring (no functional changes, no api changes).
• Build related changes.
• CI related changes.
• Documentation content changes.
• Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

• Screenshots with this changes: N/A
• Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

• Yes.
• No.

[stevenjoezhang]

See: https://www.measurethat.net/Benchmarks/Show/2978/0/lodash-merge-vs-objectassign-vs-spread

Run the benchmark: lodash merge vs object.assign vs spread - MeasureThat.net

JavaScript microbenchmarks, JavaScript performance playground. Measure performance accross different browsers.

[jiangtj]

How about to support deep copy?

[stevenjoezhang]

Like what...

[stevenjoezhang]

https://github.com/theme-next/hexo-theme-next/blob/5067852e5f5ba4883064716b530c664ec0feeafc/.gitattributes

GitHub

theme-next/hexo-theme-next

Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.

[jiangtj]

😂

[jiangtj]

Hexo support lodash

[jiangtj]

Hexo support lodash

But I don't how to use 😂

[stevenjoezhang]

I see. So it would better be
obj = Object.assign(obj, other)

[jiangtj]

I see. So it would better be
obj = Object.assign(obj, other)

I don't know, I also use Object.assign 😂 . But _.merge and Object.assign behave differently, need to pay attention or remind the user.

[1v9]

@jiangtj const merge = require('lodash/merge');

[1v9]

So, lodash merge vs Object.assign vs Spread syntax? Shallow copy? Deep copy? 😂

[stevenjoezhang]

Problems occur if a user does not copy all sub-options under a root option...
In this particular case, Object.assign and lodash.merge have different properties
Since this is a function that executes only once, the performance issue is less critical to consider
So revert it: 74f2749