Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff gas #122

Closed
wants to merge 1 commit into from
Closed

diff gas #122

wants to merge 1 commit into from

Conversation

robertu7
Copy link
Contributor

No description provided.

@thematters thematters deleted a comment from github-actions bot Nov 21, 2023
Copy link

github-actions bot commented Nov 21, 2023

Changes to gas cost

Generated at commit: fea9bacfae9c8f09fbf8bba5064050932f5d64cb, compared to commit: 2a64e229ce21722c592d92cccdd1b9511d77d103

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
Billboard getBids +51,881 ❌ +449.23%
Logbook fork
getLogs
+77,316 ❌
-12,216 ✅
+238.20%
-39.54%
BillboardRegistry getAuction
setAuctionLease
-1,331 ✅
-26,263 ✅
-41.87%
-95.55%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Billboard 5,327,637 (+126,451) addToWhitelist
calculateTax
clearAuction
getBids
getBoard
mintBoard
placeBid
setBoardContentURI
setBoardDescription
setBoardLocation
setBoardName
setBoardRedirectURI
setRegistryOperator
setTaxRate
withdrawBid
withdrawTax
2,614 (0)
2,626 (+141)
10,678 (+159)
63,430 (+51,881)
9,540 (+84)
4,809 (0)
2,670 (0)
1,816 (+12)
7,991 (+193)
7,968 (+193)
7,947 (+193)
1,772 (+12)
2,703 (0)
2,584 (0)
2,894 (+128)
1,950 (-22)
0.00%
+5.67%
+1.51%
+449.23%
+0.89%
0.00%
0.00%
+0.67%
+2.47%
+2.48%
+2.49%
+0.68%
0.00%
0.00%
+4.63%
-1.12%
23,015 (-250)
3,178 (-701)
53,201 (-21,418)
63,430 (+51,881)
10,092 (+84)
107,554 (+36)
164,482 (-75,422)
16,930 (+14)
14,207 (+193)
14,256 (+199)
14,075 (+199)
14,715 (+14)
5,706 (+45)
11,508 (-15)
20,233 (+157)
13,965 (-22)
-1.07%
-18.07%
-28.70%
+449.23%
+0.84%
+0.03%
-31.44%
+0.08%
+1.38%
+1.42%
+1.43%
+0.10%
+0.79%
-0.13%
+0.78%
-0.16%
22,688 (-2,000)
2,626 (+141)
60,720 (-34,109)
63,430 (+51,881)
9,941 (+84)
115,225 (+38)
120,816 (-124,047)
25,684 (+14)
8,322 (+193)
8,299 (+193)
8,278 (+193)
15,713 (+14)
5,706 (+45)
15,971 (-22)
5,739 (+158)
10,200 (-22)
-8.10%
+5.67%
-35.97%
+449.23%
+0.85%
+0.03%
-50.66%
+0.05%
+2.37%
+2.38%
+2.39%
+0.09%
+0.79%
-0.14%
+2.83%
-0.22%
24,688 (0)
11,126 (+141)
92,900 (-38,851)
63,430 (+51,881)
11,549 (+84)
115,225 (+38)
305,589 (-70,760)
25,684 (+14)
32,194 (+195)
32,457 (+217)
31,796 (+217)
25,663 (+14)
8,709 (+89)
15,971 (-22)
63,919 (+180)
33,512 (-22)
0.00%
+1.28%
-29.49%
+449.23%
+0.73%
+0.03%
-18.80%
+0.05%
+0.61%
+0.67%
+0.69%
+0.05%
+1.03%
-0.14%
+0.28%
-0.07%
67 (+29)
48 (+29)
7 (0)
1 (0)
8 (0)
37 (0)
70 (+29)
5 (0)
4 (0)
4 (0)
4 (0)
4 (0)
2 (0)
3 (0)
8 (0)
4 (0)
Logbook 4,517,838 (0) donate
fork
getBalance
getLogbook
getLogs
ownerOf
publish
tokenURI
transferFrom
304 (-2,237)
1,886 (0)
701 (0)
1,770 (0)
7,209 (-6,017)
625 (0)
5,729 (0)
813,260 (+111)
39,620 (0)
-88.04%
0.00%
0.00%
0.00%
-45.49%
0.00%
0.00%
+0.01%
0.00%
95,564 (-5,531)
109,774 (+77,316)
768 (+26)
6,238 (-202)
18,679 (-12,216)
642 (+2)
79,726 (+1,448)
815,412 (+2,263)
39,679 (+8)
-5.47%
+238.20%
+3.50%
-3.14%
-39.54%
+0.31%
+1.85%
+0.28%
+0.02%
2,541 (-14,356)
149,033 (+146,132)
783 (+41)
7,770 (0)
17,293 (-13,602)
625 (0)
72,864 (0)
815,412 (+2,263)
39,620 (0)
-84.96%
+5037.30%
+5.53%
0.00%
-44.03%
0.00%
0.00%
+0.28%
0.00%
283,849 (0)
160,410 (+11,377)
783 (0)
7,770 (-999)
31,537 (-17,027)
2,650 (0)
221,066 (0)
817,564 (+4,415)
41,220 (0)
0.00%
+7.63%
0.00%
-11.39%
-35.06%
0.00%
0.00%
+0.54%
0.00%
3 (0)
11 (+6)
11 (+7)
39 (+1)
3 (+1)
114 (-13)
109 (-7)
2 (+1)
81 (-13)
BillboardRegistry 2,775,732 (+81,329) auctionBidders
boards
emitAuctionCleared
emitBidWithdrawn
getAuction
getBid
leaseTerm
mintBoard
newAuction
newBid
nextBoardAuctionId
safeTransferFrom
setAuctionLease
setBoardContentURI
setBoardDescription
setBoardLocation
setBoardName
setBoardRedirectURI
setOperator
setTaxRate
setTaxTreasury
symbol
taxRate
taxTreasury
tokenURI
transferAmount
861 (-22)
4,474 (+109)
3,166 (+146)
3,063 (+22)
1,321 (-206)
1,618 (0)
492 (+42)
61,687 (+38)
28,275 (-26,050)
48,534 (-19,900)
484 (-22)
23,499 (-17)
1,222 (+270)
3,426 (+2)
23,348 (+2)
23,303 (+24)
23,326 (+24)
3,449 (+2)
3,645 (+89)
8,540 (-22)
888 (0)
1,350 (-22)
384 (0)
882 (-22)
1,510 (-22)
7,470 (0)
-2.49%
+2.50%
+4.83%
+0.72%
-13.49%
0.00%
+9.33%
+0.06%
-47.95%
-29.08%
-4.35%
-0.07%
+28.36%
+0.06%
+0.01%
+0.10%
+0.10%
+0.06%
+2.50%
-0.26%
0.00%
-1.60%
0.00%
-2.43%
-1.44%
0.00%
861 (-22)
4,500 (+97)
3,166 (+146)
3,063 (+22)
1,848 (-1,331)
4,578 (+1,894)
726 (-71)
106,178 (+38)
40,090 (-26,050)
103,459 (-12,992)
864 (-168)
23,499 (-17)
1,222 (-26,263)
18,351 (+2)
23,348 (+2)
23,303 (+24)
23,326 (+24)
16,715 (+2)
3,645 (+89)
8,540 (-22)
18,300 (+1,935)
1,391 (-22)
725 (-336)
5,791 (-113)
1,510 (-22)
12,470 (+455)
-2.49%
+2.20%
+4.83%
+0.72%
-41.87%
+70.57%
-8.91%
+0.04%
-39.39%
-11.16%
-16.28%
-0.07%
-95.55%
+0.01%
+0.01%
+0.10%
+0.10%
+0.01%
+2.50%
-0.26%
+11.82%
-1.56%
-31.67%
-1.91%
-1.44%
+3.79%
861 (-22)
4,474 (+109)
3,166 (+146)
3,063 (+22)
1,321 (-206)
1,618 (0)
492 (+42)
107,487 (+38)
48,175 (-26,050)
88,732 (-18,286)
484 (-22)
23,499 (-17)
1,222 (-39,530)
23,326 (+2)
23,348 (+2)
23,303 (+24)
23,326 (+24)
23,349 (+2)
3,645 (+89)
8,540 (-22)
20,788 (0)
1,350 (-22)
384 (0)
6,882 (-22)
1,510 (-22)
7,470 (0)
-2.49%
+2.50%
+4.83%
+0.72%
-13.49%
0.00%
+9.33%
+0.04%
-35.10%
-17.09%
-4.35%
-0.07%
-97.00%
+0.01%
+0.01%
+0.10%
+0.10%
+0.01%
+2.50%
-0.26%
0.00%
-1.60%
0.00%
-0.32%
-1.44%
0.00%
861 (-22)
4,985 (+109)
3,166 (+146)
3,063 (+22)
5,321 (-6,206)
9,618 (0)
2,492 (+42)
107,487 (+38)
48,175 (-26,050)
146,818 (0)
2,484 (-22)
23,499 (-17)
1,222 (-39,530)
23,326 (+2)
23,348 (+2)
23,303 (+24)
23,326 (+24)
23,349 (+2)
3,645 (+89)
8,540 (-22)
20,788 (0)
3,350 (-22)
2,384 (0)
6,882 (-22)
1,510 (-22)
32,470 (0)
-2.49%
+2.24%
+4.83%
+0.72%
-53.84%
0.00%
+1.71%
+0.04%
-35.10%
0.00%
-0.88%
-0.07%
-97.00%
+0.01%
+0.01%
+0.10%
+0.10%
+0.01%
+2.50%
-0.26%
0.00%
-0.65%
0.00%
-0.32%
-1.44%
0.00%
13 (+11)
88 (+29)
36 (0)
2 (0)
144 (+29)
100 (+40)
179 (+58)
35 (0)
32 (0)
68 (+29)
105 (+29)
1 (0)
36 (0)
4 (0)
1 (0)
1 (0)
1 (0)
3 (0)
1 (0)
2 (0)
8 (-1)
48 (0)
117 (+58)
11 (-1)
1 (0)
10 (-1)

@robertu7 robertu7 closed this Nov 21, 2023
@gitwoz gitwoz deleted the feat/diff-gas-1 branch August 29, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant