Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billboard #120

Merged
merged 55 commits into from
Dec 19, 2023
Merged

Billboard #120

merged 55 commits into from
Dec 19, 2023

Conversation

robertu7
Copy link
Contributor

No description provided.

zeckli and others added 21 commits November 1, 2023 00:12
@zeckli
Create the first version of Billboard contracts.
1d3e54b
@zeckli
Fix typos.
38780e5
@zeckli
Add test cases for Billboard.
37baf4a
@zeckli
Add test cases realted to board settings.
29971b5
@zeckli
Add test cases realted to board settings.
e555872
@zeckli
Add test cases realted to board settings.
1981fed
@zeckli
Change method setBoardRedirectLink to setBoardRedirectURI.
4d88474
@zeckli
Remove unnecessary address(0) checker since transaction will be failed.
ce5b45a
@zeckli
Add basic assert for auction and registry upgradability.
ec152ec
@zeckli
Rename Board property owner to creator.
7841bbe
@zeckli
Remove unnecessary address validator from modifiers.
5e989e9
@zeckli
Add more test cases for transferring and minting.
7c28cf2
@zeckli
Add white list for basic access control.
fb23fb4
@robertu7
feat(billboard): revise interface
6428a16
@robertu7
feat(billboard): impls of BillboardRegistry
b19e8b6
@robertu7
feat(billboard): impls getters and basic setters
490cbd1
@robertu7
feat(billboard): add lease to Auction
98f620d
@robertu7
feat(billboard): impl clearAuction
ad3886e
@robertu7
feat(billboard): impl placeBid
21b5b2e
@robertu7
feat(billboard): move bidders and bids out of Auction struct
a098934
@robertu7
fix(billboard): fix formatter
842ebe8
zeckli
zeckli reviewed Nov 14, 2023
View reviewed changes
src/Billboard/Billboard.sol Outdated Show resolved Hide resolved
@robertu7 robertu7 changed the title WIP: Billboard: auction Billboard: auction Nov 20, 2023
zeckli
zeckli reviewed Nov 21, 2023
View reviewed changes
src/Billboard/Billboard.sol Outdated Show resolved Hide resolved
src/Billboard/Billboard.sol Outdated Show resolved Hide resolved
src/Billboard/BillboardRegistry.sol Outdated Show resolved Hide resolved
@robertu7 robertu7 mentioned this pull request Nov 21, 2023
Closed
@robertu7 robertu7 changed the title Billboard: auction Billboard Nov 21, 2023
@robertu7 robertu7 changed the base branch from billboard to develop November 21, 2023 11:14
@robertu7 robertu7 force-pushed the feat/billboard-auction branch from 983c67c to 1a53d3c Compare November 21, 2023 11:27
@robertu7 robertu7 force-pushed the feat/billboard-auction branch from 1a53d3c to 001e7b2 Compare November 21, 2023 11:30
@robertu7 robertu7 force-pushed the feat/billboard-auction branch from 4d37891 to 10389c7 Compare November 21, 2023 12:13
@robertu7 robertu7 merged commit d185b2f into develop Dec 19, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/billboard-auction branch December 19, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeckli zeckli zeckli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertu7 @zeckli