feat(billboard): add tests for mintBoard

thematters · Nov 15, 2023 · 32f96d5 · 32f96d5
1 parent d282702
commit 32f96d5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/src/Billboard/Billboard.sol b/src/Billboard/Billboard.sol
@@ -94,11 +94,11 @@ contract Billboard is IBillboard {
 
     /// @inheritdoc IBillboard
     function mintBoard(address to_) external {
-        if (!isOpened && whitelist[msg.sender] != true) {
+        if (isOpened || whitelist[msg.sender] == true) {
+            registry.mintBoard(to_);
+        } else {
             revert Unauthorized("whitelist");
         }
-
-        registry.mintBoard(to_);
     }
 
     /// @inheritdoc IBillboard

diff --git a/src/test/Billboard/BillboardTest.t.sol b/src/test/Billboard/BillboardTest.t.sol
@@ -90,7 +90,7 @@ contract BillboardTest is BillboardTestBase {
 
         // mint
         operator.mintBoard(ADMIN);
-        assertEq(1, registry.balanceOf(ADMIN));
+        assertEq(registry.balanceOf(ADMIN), 1);
 
         // get board & check data
         IBillboardRegistry.Board memory board = operator.getBoard(1);
@@ -104,17 +104,26 @@ contract BillboardTest is BillboardTestBase {
 
         // mint again for checking id generator
         operator.mintBoard(ADMIN);
-        assertEq(2, registry.balanceOf(ADMIN));
+        assertEq(registry.balanceOf(ADMIN), 2);
         board = operator.getBoard(2);
         assertEq(board.creator, ADMIN);
     }
 
-    // function testMintBoardByAttacker() public {
-    //     vm.startPrank(ATTACKER);
+    function testMintBoardIfOpened() public {
+        vm.startPrank(ADMIN);
+        operator.setIsOpened(true);
 
-    //     vm.expectRevert(abi.encodeWithSignature("Unauthorized(string)", "creator"));
-    //     operator.mintBoard(ATTACKER);
-    // }
+        vm.startPrank(USER_A);
+        operator.mintBoard(USER_A);
+        assertEq(registry.balanceOf(USER_A), 1);
+    }
+
+    function testMintBoardByAttacker() public {
+        vm.startPrank(ATTACKER);
+
+        vm.expectRevert(abi.encodeWithSignature("Unauthorized(string)", "whitelist"));
+        operator.mintBoard(ATTACKER);
+    }
 
     // function testSetBoardProperties() public {
     //     _mintBoard();