Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove join, nick and whois inputs, they are cleanly handled by the server #208

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Remove join, nick and whois inputs, they are cleanly handled by the server #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/js/lounge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ $(function() {
"/notice",
"/op",
"/part",
"/query",
"/quit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why removing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an alias for /whois, and since that's gone, that wouldn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was (see src/plugins/inputs/whois.js, below). I'm guessing @astorije assumed, as I did at first glance, that /query was an alias for /msg. That is the common usage among other clients.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well not exactly an alias for /msg, as some clients don't open a query window for /msg, and just show the message sent/received in the server window and only show a query window when you do /query.

But certanarily, I don't like that, so it's essentially the same thing. The important thing is that it opens a query window, but does /query still do a whois by default, or do you have to do /whois for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall using any client that auto-whois'd on /query, no. But I also don't recall using any that didn't open a query window for /msg, so maybe I have limited experience.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xPaw, my bad for forgetting that /query was merely an alias for /whois...

"/raw",
"/say",
Expand Down
3 changes: 0 additions & 3 deletions src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,12 @@ var events = [
var inputs = [
// These inputs are sorted in order that is most likely to be used
"msg",
"whois",
"part",
"action",
"connect",
"invite",
"join",
"kick",
"mode",
"nick",
"notice",
"quit",
"raw",
Expand Down
10 changes: 0 additions & 10 deletions src/plugins/inputs/join.js
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/plugins/inputs/nick.js
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/plugins/inputs/whois.js
View file
Open in desktop

This file was deleted.