Refactor predict function #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ks/v0.12.0 #243 +/- ##
===========================================
Coverage 88.73% 88.73%
===========================================
Files 8 8
Lines 364 364
Branches 59 56 -3
===========================================
Hits 323 323
Misses 41 41
Continue to review full report at Codecov.
|
thekevinscott
added a commit
that referenced
this pull request
Mar 5, 2022
* Refactor to generator (#234) * Refactor predict to be a generator function * Refactor upscale function into a generator (#236) * Move yielding to wrapper upscale function (#237) * Add abort signal to enable cancellation (#238) * Update version script (#239) * Update version script to also update dependencies * Cancel method integration test (#240) * Migrate progress test to upscale * Add integration test for cancel * Refactor upscale method to accept an internal args object (#241) * Refactor predict function (#243) * Refactor predict function * Insist on parameters for sub upscale functions * Refactor upscaling code to have better types around async generator return values (#242) * Rearrange upscale functions to be typed better and add a memory leak test * Set up a generator wrap function (#244) * Set up a generator wrap function * Add test for wrapGenerator function * Strengthen tests around generator wrap * Remove console logs * Add test to cover console warn * Add coverage to isAborted method * Cancel method memory leak test (#245) * Add unit test for memory allocation in predict function * Update docs (#246) * Fix examples (#247) * Bump to latest version and add babelrc * Migrate examples to use esbuild instead of parcel * Remove yarnrc from repo * Ignore yarnrc * Cancel example (#248) * Add abort signal to enable cancellation * Initial commit for cancel example * Merge upstream * Implement cancel example * Initialize value as undefined (#249) * Add top level abort (#250) * Add a top level abort * Add an integration test for cancel * Update documentation * Fix deepsource issue * Add exception for consoles (#251)
thekevinscott
added a commit
that referenced
this pull request
Mar 5, 2022
* Refactor to generator (#234) * Refactor predict to be a generator function * Refactor upscale function into a generator (#236) * Move yielding to wrapper upscale function (#237) * Add abort signal to enable cancellation (#238) * Update version script (#239) * Update version script to also update dependencies * Cancel method integration test (#240) * Migrate progress test to upscale * Add integration test for cancel * Refactor upscale method to accept an internal args object (#241) * Refactor predict function (#243) * Refactor predict function * Insist on parameters for sub upscale functions * Refactor upscaling code to have better types around async generator return values (#242) * Rearrange upscale functions to be typed better and add a memory leak test * Set up a generator wrap function (#244) * Set up a generator wrap function * Add test for wrapGenerator function * Strengthen tests around generator wrap * Remove console logs * Add test to cover console warn * Add coverage to isAborted method * Cancel method memory leak test (#245) * Add unit test for memory allocation in predict function * Update docs (#246) * Fix examples (#247) * Bump to latest version and add babelrc * Migrate examples to use esbuild instead of parcel * Remove yarnrc from repo * Ignore yarnrc * Cancel example (#248) * Add abort signal to enable cancellation * Initial commit for cancel example * Merge upstream * Implement cancel example * Initialize value as undefined (#249) * Add top level abort (#250) * Add a top level abort * Add an integration test for cancel * Update documentation * Fix deepsource issue * Update changelog and versions * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further refactor core
upscalefunction andpredictfunction