Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shipa-2799] - Starting process via Ketch CLI outputs "Successfully started!" when passing invalid process name #254

Merged
merged 3 commits into from
May 26, 2022
Merged

[shipa-2799] - Starting process via Ketch CLI outputs "Successfully started!" when passing invalid process name #254

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb4cf6c
modified Start process via selector bug
kavinaravind May 25, 2022
b12a7fe
fixed typo for app start command
kavinaravind May 26, 2022
cf87cb7
Delete coverage.txt
kavinaravind May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/api/v1beta1/app_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ func (app *App) Start(selector Selector) error {
for i, processSpec := range deploymentSpec.Processes {
if processSpec.Name == *selector.Process && (processSpec.Units == nil || *processSpec.Units == 0) {
deploymentSpec.Processes[i].Units = &units
deploymentFound = true
}
}
} else {
Expand All @@ -433,11 +434,11 @@ func (app *App) Start(selector Selector) error {
continue
}
deploymentSpec.Processes[i].Units = &units
deploymentFound = true
}
}
deploymentFound = true
}
if selector.DeploymentVersion != nil && !deploymentFound {
if (selector.DeploymentVersion != nil || selector.Process != nil) && !deploymentFound {
return ErrDeploymentNotFound
}
return nil
Expand Down