Shipa 2578 pr

[DavisFrench]

Description

Apps can now be deployed as a statefulset if the type in appSpec is specified as "StatefulSet", and volumeClaimTemplates are provided. The default type for apps is deployment.

Both deployment and statefulset use AppDeploymentEvent. I'm treating an app deployment (in terms of ketch) as type independent (when it comes to statefulset versus deployment in k8s). It is possible to create unique events based on which type of deployment if need be.

This PR addresses the comments left by @aleksej-paschenko in this PR, which I will close in favor of this one after this gets merged.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Chore (documentation addition or typo, file relocation)

Testing

• New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
• This change requires no testing (i.e. documentation update)

Documentation

• All added public packages, funcs, and types have been documented with doc comments
• I have commented my code, particularly in hard-to-understand areas

Final Checklist:

• I followed standard GitHub flow guidelines
• I have performed a self-review of my own code
• My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

[aleksej-paschenko]

looks great!
lets discuss which PR we want to merge
@stinkyfingers @koncar