Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a cache when creating a new helm client to avoid initialization #220

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Use a cache when creating a new helm client to avoid initialization #220

merged 2 commits into from
Jan 13, 2022

Conversation

aleksej-paschenko
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko commented Jan 13, 2022 •
edited
Loading

we are not alone trying to find a workaround for the memory consumption
helm/helm#10374
it looks like having a per-namespace cache for action.Configuration should help
(according to helm/helm#10374 (comment) )

stinkyfingers
stinkyfingers approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@stinkyfingers stinkyfingers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

@aleksej-paschenko aleksej-paschenko merged commit f44fcb2 into main Jan 13, 2022
@aleksej-paschenko aleksej-paschenko deleted the factory branch January 13, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinkyfingers stinkyfingers stinkyfingers approved these changes

@koncar koncar koncar approved these changes

@DavisFrench DavisFrench DavisFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksej-paschenko @stinkyfingers @koncar @DavisFrench