Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds withCancel to app watcher #218

Merged
merged 2 commits into from
Jan 13, 2022
Merged

adds withCancel to app watcher #218

merged 2 commits into from
Jan 13, 2022

Conversation

stinkyfingers
Copy link
Contributor

Description

Adds a map[deploymentName]cancelFunc field to the App Reconciler. During every reconcile, the previous deployment's event-watching goroutine is terminated and the current one stored on the map. The intent is to prevent runaway goroutines when a reconciler is called repeatedly.

Fixes # 2339

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@aleksej-paschenko aleksej-paschenko merged commit 198bbe0 into main Jan 13, 2022
@aleksej-paschenko aleksej-paschenko deleted the app-ctx branch January 13, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants