Keep only 1 historical helm release per app on cluster #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksej-paschenko
force-pushed
the
max-history
branch
from
fb42d13 to
3ba5649
Compare
Currently, we don't specify MaxHistory and a number of helm releases keeps growing meaning ketch creates lots of secrets named "sh.helm.release.v1.<app-name>.v<version>".
aleksej-paschenko
changed the title
itsksaurabh
reviewed
Dec 21, 2021
internal/chart/helm_client.go
Outdated
| @@ -91,6 +94,10 @@ func (c HelmClient) UpdateChart(tv TemplateValuer, config ChartConfig, opts ...I | |||
| } | |||
| updateClient := action.NewUpgrade(c.cfg) | |||
| updateClient.Namespace = c.namespace | |||
| // MaxHistory=0 means there is an unlimited number of k8s secrets per application, | |||
There was a problem hiding this comment.
We might need to update comments, we are only mentioning secrets here but helm docs say:
MaxHistory specifies the maximum number of historical releases that will be retained, including the most recent release.
Values of 0 or less are ignored (meaning no limits are imposed).
itsksaurabh
approved these changes
Dec 21, 2021
aleksej-paschenko
force-pushed
the
max-history
branch
from
3ba5649 to
140e501
Compare
stinkyfingers
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't specify MaxHistory and a number of helm releases
keeps growing meaning ketch creates lots of secrets named
sh.helm.release.v1.<app-name>.v<version>.Type of change