Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIPA-2130] Port CI to Github Actions from Travis #194

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

stinkyfingers
Copy link
Contributor

Description

Ports TravisCI to GH Actions. Moving Ketch's repo to theketchio org broke TravisCI, as we have too many users for the default free plan. We're heading to GHActions anyway.

I had trouble getting Istio installed on Minikube running on GHActions machines (this has been an issue in the past), so I ported Integration Testing over to K3D. It seems to work fine. Occasionally Traefik installation would fail with errors indicating it was already installed in a different namespace, so I opted to uninstall+install just to be thorough.

Fixes # 2130

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

fix docker step

update dockerhub action

update dockerhub action part 2

update dockerhub action part 3

update dockerhub action part 4

update dockerhub action part 5

don't install minikube

use k3d

move commans to deploy file

traefik installed already

where are tests

correct dir, re-add traefik

correct dir, re-add traefik

uninstall traefik

install bats

cleanup

always push to dockerhub

always push to dockerhub
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome

helm install ingress-nginx ingress-nginx/ingress-nginx

# wait for containers
kubectl wait --for=condition=Ready=true pod -n cert-manager --all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# nginx
helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx
helm repo update
helm install ingress-nginx ingress-nginx/ingress-nginx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also do helm install --wait --timeout=5m ingress-nginx ingress-nginx/ingress-nginx

@stinkyfingers stinkyfingers merged commit 0998f9b into main Nov 16, 2021
@stinkyfingers stinkyfingers deleted the shipa-2130 branch November 16, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants