Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post render #192

Merged
merged 8 commits into from
Nov 16, 2021
Merged

Post render #192

merged 8 commits into from
Nov 16, 2021

Conversation

aleksej-paschenko
Copy link
Contributor

No description provided.

@DavisFrench
Copy link
Contributor

If the framework where the app is being deployed to contains a configmap that has a name like some-name-postrender (the postrender being present is the important part), the contents of that config map will be applied to the apps helmchart before being deployed.

The config map itself should contain a kustomization.yaml key with its corresponding contents as the value, and any other needed yaml files (e.g. patch.yaml) as keys with the contents as the value. These yamls should be under the configmap's data key.

Copy link
Contributor Author

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome!

Copy link
Contributor Author

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, would it be much work to add a test?

@aleksej-paschenko
Copy link
Contributor Author

Looks awesome!

@aleksej-paschenko
Copy link
Contributor Author

aleksej-paschenko commented Nov 16, 2021

@stinkyfingers @DavisFrench if it works for you, let's approve it and merge, I can't approve this PR because it was opened by me

@DavisFrench DavisFrench merged commit b36e29d into main Nov 16, 2021
@DavisFrench DavisFrench deleted the post-render branch November 16, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants