Job CRD #116
Merged
Job CRD #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinkyfingers
force-pushed
the
jds/job-crd
branch
from
c5eec60 to
7d98f61
Compare
stinkyfingers
force-pushed
the
jds/job-crd
branch
2 times, most recently
from
4d229fa to
911320e
Compare
WIP parking adds generated job template; controller updates addtl cleanup refactors some chart operations; converts job.command to job.containers adds unit tests; refactors AppCondition fixes one merge conflict rm unneeded tests manifests update stubs out Job WIP parking adds generated job template; controller updates addtl cleanup refactors some chart operations; converts job.command to job.containers adds unit tests; refactors AppCondition fixes one merge conflict rm unneeded tests reset manager controller name add jobs to framework status
stinkyfingers
force-pushed
the
jds/job-crd
branch
from
911320e to
c01dd8e
Compare
aleksej-paschenko
requested changes
Jul 21, 2021
cmd/manager/main.go
Outdated
| @@ -87,6 +87,10 @@ func main() { | |||
| setupLog.Error(err, "unable to set default templates") | |||
| os.Exit(1) | |||
| } | |||
| if err = storage.Update(templates.IngressConfigMapName("none"), templates.NoIngressTemplates); err != nil { | |||
There was a problem hiding this comment.
how about templates.JobConfigMapName() and templates.JobTemplates?
There was a problem hiding this comment.
Good call, change made. Deciding what to call this was something I was unsure of.
internal/api/v1beta1/job_types.go
Outdated
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| // EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! |
There was a problem hiding this comment.
let's remove this comment)
internal/templates/generator/main.go
Outdated
| Traefik bool | ||
| Istio bool | ||
| Common bool | ||
| NoIngress bool |
There was a problem hiding this comment.
How about Job instead of NoIngress?
There was a problem hiding this comment.
Good call. Renamed all NoIngress -> Job.
internal/templates/storage.go
Outdated
| @@ -71,6 +71,9 @@ var ( | |||
| TraefikDefaultTemplates = Templates{ | |||
| Yamls: GeneratedYamls.TraefikYamls, | |||
| } | |||
| NoIngressTemplates = Templates{ | |||
| Yamls: GeneratedYamls.NoIngressYamls, | |||
There was a problem hiding this comment.
GeneratedYamls.NoIngressYamls?
aleksej-paschenko
approved these changes
Jul 21, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Job CRD/Controller. Spec.
Quickstart:
make uninstallmake manager install- assure job CRD is live:k get crd(Missing "Jobs" CRD?kubectl apply -f config/crd/bases/theketch.io_jobs.yaml./bin/manager --enable-leader-election=false --disable-webhooks- run managerkubectl apply -f sample-ketch-job.yaml(assumes you have framework "myframework" created")kubectl get jobs -Akubectl get pods -Akubectl logs <pod> -n ketch-myframework piandkubectl logs <pod> -n ketch-myframework listerkubectl delete -f sample-ketch-job.yaml(should remove the job, i.e.kubectl get jobs -Ashows no "crd-test")sample-ketch-job.yaml:
kubectl get jobs -n ketch-myframeworkkubectl get pods -n ketch-myframeworkkubectl logs <pod> -n ketch-myframework pi- for "pi" container in jobkubectl logs <pod> -n ketch-myframework lister- for "ls /" container in jobFixes # 1541
Type of change
Testing
Documentation
Final Checklist:
Additional Information (omit if empty)
Please include anything else relevant to this PR that may be useful to know.