Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scib.cl.cluster_optimal_resolution in metrics wrapper #405

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

mumichae
Copy link
Collaborator

@mumichae mumichae commented Apr 1, 2024

No description provided.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.41%. Comparing base (59ae6ee) to head (c409c2b).
Report is 2 commits behind head on main.

❗ Current head c409c2b differs from pull request most recent head c75926f. Consider uploading reports for the commit c75926f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   52.81%   49.41%   -3.41%     
==========================================
  Files          22       22              
  Lines        1882     1882              
==========================================
- Hits          994      930      -64     
- Misses        888      952      +64     
Flag Coverage Δ
unittests 49.41% <100.00%> (-3.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scib/metrics/metrics.py 81.31% <100.00%> (ø)

... and 3 files with indirect coverage changes

@mumichae mumichae changed the title Use new clustering function in metrics wrapper Use scib.cl.cluster_optimal_resolution in metrics wrapper Apr 17, 2024
@mumichae mumichae merged commit 127e41e into main Apr 17, 2024
10 checks passed
@mumichae mumichae deleted the update_clustering_default branch April 17, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant