Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make documentation consistent with code #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grst
Copy link

@grst grst commented Oct 17, 2019

Update full and reduced scale parameters in documentation to be consistent with code:

full_formula_loc = '~ 1 + grouping'
full_formula_scale = '~ 1'
reduced_formula_loc = '~ 1'
reduced_formula_scale = '~ 1'

While being mathematically equivalent (I think...) I got confused when trying to understand the code.

Update full and reduced scale parameters in documentation to be consistent with code:
https://github.com/theislab/diffxpy/blob/dfe8304db9bba93dfc7efebebecdc62512ca6c16/diffxpy/testing/tests.py#L862-L865


While being mathematically equivalent (I think...) I got confused when trying to understand the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant