Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usesHandleParameter test returns incorrect result for Firefox 67 #178

Closed
jason0x43 opened this issue Jun 7, 2019 · 0 comments
Closed

usesHandleParameter test returns incorrect result for Firefox 67 #178

jason0x43 opened this issue Jun 7, 2019 · 0 comments

Comments

@jason0x43
Copy link
Member

For at least Firefox 67 with geckodriver 0.24.0, the usesHandleParameter feature test returns an incorrect result due to a string case issue. It's looking for "Missing.*handle", but the error FF is returning contains missing field `handle`.
@jason0x43 jason0x43 mentioned this issue Jun 7, 2019
Closed
jason0x43 added a commit that referenced this issue Jun 7, 2019
@jason0x43
Fix usesHandleParameter feature test
0ce7260 
The feature test wasn't corrently interpreting an error from at least
Firefox 67 due to a string case mismatch.

According to the webdriver spec, the error should be an InvalidArgument
error, so the test now primarily looks for that, and falls back to
checking the message text.

fixes #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason0x43