Skip to content

Commit

Permalink
Fix locator typings in Command
Browse files Browse the repository at this point in the history
The third generic field for Locator should have been be a 'pass thru'
typing for Command, using StringResult rather than string.

fixes #172
  • Loading branch information
jason0x43 committed Apr 29, 2019
1 parent f3673b8 commit 9d3ad81
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/api.json
Original file line number Diff line number Diff line change
Expand Up @@ -10054,8 +10054,8 @@
"name": "P"
},
{
"type": "intrinsic",
"name": "string"
"type": "typeParameter",
"name": "StringResult"
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion src/Command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export default class Command<T, P = any, StringResult = string>
extends Locator<
Command<Element, P, string>,
Command<Element[], P, string[]>,
Command<void, P, string>
Command<void, P, StringResult>
>
implements PromiseLike<T> {
/**
Expand Down

0 comments on commit 9d3ad81

Please sign in to comment.