Skip to content

Commit

Permalink
Fix typings for Command element find all methods (#170)
Browse files Browse the repository at this point in the history
* Use conditional types for the Command methods that run on Element to properly indicate whether the method returns a string or a string array.

* Update the declaration of Command#getAttribute to correctly indicate that a string or at string array is returned.

* Change the declaration of Command#getAttribute to support passing a type as a generic to not break code that was previously using the method.
  • Loading branch information
edhager authored and jason0x43 committed Mar 29, 2019
1 parent 92d3c76 commit 8152ff0
Show file tree
Hide file tree
Showing 3 changed files with 294 additions and 251 deletions.
Loading

0 comments on commit 8152ff0

Please sign in to comment.