Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intern config: add support for 'internLoaderPath' in loader options #1161

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

msssk
Copy link
Contributor

@msssk msssk commented May 28, 2020

Intern has built-in wrappers for Dojo, Dojo2, and SystemJS loaders. It assumes that the loader package is installed in node_modules. This PR adds support for an extra loader option to specify the location of the loader script file.

Closes #872

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #1161 into 4.x will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.x    #1161      +/-   ##
==========================================
+ Coverage   61.44%   61.54%   +0.09%     
==========================================
  Files          61       61              
  Lines        4980     4985       +5     
  Branches     1107     1110       +3     
==========================================
+ Hits         3060     3068       +8     
+ Misses       1920     1917       -3     
Impacted Files Coverage Δ
src/loaders/dojo.ts 100.00% <100.00%> (ø)
src/loaders/dojo2.ts 100.00% <100.00%> (ø)
src/loaders/systemjs.ts 95.23% <100.00%> (+15.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update babedd6...07a7525. Read the comment docs.

@msssk msssk requested a review from jason0x43 May 29, 2020 04:06
@msssk msssk marked this pull request as ready for review May 29, 2020 04:06
Copy link
Member

@jason0x43 jason0x43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. This looks great!

@jason0x43 jason0x43 merged commit 9024f8b into theintern:4.x Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants