This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
CHE-9836 add output channel API #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
approved these changes
Jun 18, 2018
benoitf
approved these changes
Jun 18, 2018
mmorhun
approved these changes
Jun 19, 2018
|
|
||
| export class OutputChannelImpl implements theia.OutputChannel { | ||
|
|
||
| private _proxy: OutputChannelRegistryMain; |
There was a problem hiding this comment.
According to https://github.com/theia-ide/theia/wiki/Coding-Guidelines: Do not use "_" as a prefix for private properties
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define output channel API for plugin model.
Related issue: eclipse-che/che#9836
Signed-off-by: Oleksii Orel oorel@redhat.com