Add Legacy PSR Container Support (#103) #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the Platform to 7.4 and allow `psr/container` ^1 or ^2. * Update the docblock. * Allow nullable property. * Set the container based on which version of the ContainerInterface is present. * Add Container classes for support of psr/container 1.0.x, and 1.1.x. * Unit test code cleanup. * Change AbstractContainer constructor to Interface. * Resolve incorrect Unit test.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
===========================================
+ Coverage 3.90% 4.80% +0.90%
- Complexity 333 345 +12
===========================================
Files 33 35 +2
Lines 794 811 +17
===========================================
+ Hits 31 39 +8
- Misses 763 772 +9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the Platform to 7.4 and allow
psr/container^1 or ^2.Update the docblock.
Allow nullable property.
Set the container based on which version of the ContainerInterface is present.
Add Container classes for support of psr/container 1.0.x, and 1.1.x.
Unit test code cleanup.
Change AbstractContainer constructor to Interface.
Resolve incorrect Unit test.