Merge pull request #9 from thefrontside/cl/add-doctype

✨ Add <!doctype html> to html serialization
thefrontside · Sep 6, 2024 · 5c2a1be · 5c2a1be
2 parents 7f34b14 + 5b8223d
commit 5c2a1be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/middleware/serialize-html.ts b/lib/middleware/serialize-html.ts
@@ -3,7 +3,9 @@ import type { HASTHtmlNode } from "../types.ts";
 import { toHtml } from "npm:hast-util-to-html@9.0.0";
 
 export function serializeHtml(node: HASTHtmlNode): Response {
-  return new Response(toHtml(node), {
+  let doctype = { type: "doctype" } as const;
+
+  return new Response(toHtml([doctype, node]), {
     headers: {
       "Content-Type": "text/html; charset=utf-8;",
     },

diff --git a/test/revolution.test.tsx b/test/revolution.test.tsx
@@ -152,7 +152,7 @@ describe("revolution", () => {
 
     expect(response.status).toEqual(200);
     expect(yield* response.text()).toEqual(
-      "<html><body>Hello World</body></html>",
+      "<!doctype html><html><body>Hello World</body></html>",
     );
   });
 
@@ -204,7 +204,7 @@ describe("revolution", () => {
     let response = yield* fetch(`http://${hostname}:${port}`, { signal });
 
     expect(yield* response.text()).toEqual(
-      "<html><body><div>Banner</div>Hello World</body></html>",
+      "<!doctype html><html><body><div>Banner</div>Hello World</body></html>",
     );
   });
 });