- add name to attribute bindings to specify a form element name #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just added the remaining attributes: autofocus, form, required, size |
|
Looks good to me. @cowboyd think we can get this merged? |
|
Looks great! Once we get some tests wrapped around this, merge is a go. |
|
Sorry for the delay. I hope the tests are fine; wasn't sure to check for more than just the attribute binding. I appreciate any feedback! |
|
Unlike the Nice work! |
|
Those tests were exactly what I was looking for. Mostly, I just want to prevent any accidental regressions on those attributes. 👍 |
cowboyd
added a commit
that referenced
this pull request
Apr 7, 2015
- add name to attribute bindings to specify a form element name
|
I'll go ahead and close #11, since this pull request fixes that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.