Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing attributes #11

Closed
jonkoops opened this issue Apr 3, 2015 · 1 comment
Closed

Add support for missing attributes #11

jonkoops opened this issue Apr 3, 2015 · 1 comment

Comments

@jonkoops
Copy link

jonkoops commented Apr 3, 2015

Currently the x-select component supports a limited amount of the available attributes on a normal HTML select. The attributes that are currently not present on the component are as follows:

  • autofocus
  • form
  • required
  • size

For a complete overview of the available attributes and their functionality see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select#attributes

Some of these attributes will probably not be applicable to most Ember applications (mostly form and name), but they should probably be added as well to support some edge cases. Other attributes like required and autofocus are obviously pretty useful.

I can whip up a pull request to add these attributes, but I wanted to do a quick check if anyone has issues with adding these attributes.

@cowboyd
Copy link
Collaborator

cowboyd commented Apr 3, 2015

A pull request would be very much appreciated! There is #10 which is outstanding, but I think it makes sense to roll them all into one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants