Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Backport withResolvers() from v4 to v3 #963

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Jan 12, 2025

Motivation

withResolvers() is a key API and for continuing back to a point and are necessary to fill hole left by deprecating the operation version of action().

Approach

This is pretty much a straight copy and paste. Some of the imports had to be re-arranged, and the expect library needed to be upgraded.

It also brings the rosetta stone entry forward

`withResolvers()` is a key API and for continuing back to a point and
are necessary to fill hole left by deprecating the operation version
of `action()`.

This is pretty much a straight copy and paste. Some of the imports had
to be re-arranged, and the expect library needed to be upgraded.

It also brings the rosetta stone entry forward
@cowboyd cowboyd requested review from taras and neurosnap January 12, 2025 02:54
@cowboyd cowboyd enabled auto-merge January 12, 2025 02:55
@cowboyd cowboyd merged commit e378114 into v3 Jan 14, 2025
5 checks passed
@cowboyd cowboyd deleted the cl/with-resolvers-v3-backport branch January 14, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants