📝 update the suspend() docs to account for v4 API
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suspend operation is no longer fundamental. It is just an action that does nothing, so we had to update the docs to reflect that. We had to change not only the API docs, but I also noticed that there wer several places where the old `action+suspend` trick was being used that are no longer valid.
Co-authored-by: David Brochart <david.brochart@gmail.com>
The suspend operation is no longer fundamental. It is just an action that does nothing, so we had to update the docs to reflect that. We had to change not only the API docs, but I also noticed that there wer several places where the old `action+suspend` trick was being used that are no longer valid.
|
Thanks as alway @davidbrochart! I really appreciate the time you have taken to proofread changes to our docs in this PR and so many others. |
|
Thank you for merging, I hope I will contribute in a more significant way in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The suspend operation is no longer fundamental. It is just an action that does nothing, so we had to update the docs to reflect that.
Approach
We had to change not only the API docs, but I also noticed that there were several places where the old
action+suspendtrick was being used that are no longer valid.