📝 Document the new action interface in v4 #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `action()` interface has been greatly simplifield for v4 bringing it almost completely in line with the `new Promise()` constructor. This adds docs for both the function and also the rosetta stone entry.
cowboyd
commented
Jan 2, 2025
| * @return a "finally" function that is _always_ run whether the | ||
| * action is resolved, rejected, or discarded. | ||
| */ | ||
| interface Executor<T> { |
There was a problem hiding this comment.
This was renamed to Executor because that's the terminology used by the Promise constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
action()interface has been greatly simplifield for v4 bringing it almost completely in line with thenew Promise()constructor.Approach
This adds docs for both the function and also the rosetta stone entry.