🚀 Performance improvements to docs based on Lighthouse recommendations #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras
force-pushed
the
tm/fix-lighthouse-suggestions
branch
from
0cf0d2b to
6110143
Compare
taras
changed the title
|
I noticed that not just the performance, but also the accessibility score improved. |
cowboyd
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Oops! It looks like the syntax highlight CSS is not loading in the preview https://effection--tm-fix-lighthouse-suggesti.deno.dev/docs/resources
I wonder what's going on. There are some warnings on the console:
|
@cowboyd try it now |
cowboyd
approved these changes
Nov 2, 2023
taras
changed the title
@cowboyd, what is the branch protection rule that's not satisfied? |
|
@taras It looks like your commits aren't signed... |
 Signed-off-by: Taras Mankovski <taras@frontside.com>
Signed-off-by: Taras Mankovski <taras@frontside.com>
Signed-off-by: Taras Mankovski <taras@frontside.com>
Signed-off-by: Taras Mankovski <taras@frontside.com>
@see https://stackoverflow.com/a/46750893 Signed-off-by: Taras Mankovski <taras@frontside.com>
taras
force-pushed
the
tm/fix-lighthouse-suggestions
branch
from
f870a1f to
777a869
Compare
|
@cowboyd I pushed signed commits, but it's still not happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that Effection docs site is loading slowly.
Approach
Add preload to CSS resource as per recommendations.
Added width/height to images to prevent render jank
Increased contracts of links in the footer
Updated dependencies
Screenshots