✨Beef up the call() function to promises and async fns
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowboyd
force-pushed
the
beef-up-call
branch
5 times, most recently
from
a4e8651 to
a08b9c0
Compare
neurosnap
approved these changes
Nov 1, 2023
Right now there are a lot of different ways to convert values into operations. There is `expect()` (Promise->Operation), `call()(Operation->Operation)`, and `op` (Function -> Operation>. starfx [unifies all of these concepts into a single operation](https://github.com/neurosnap/starfx/blob/main/fx/call.ts) We should bring this into Effection core. This adds the following variations ```ts // promise call(Promise.resolve("hello")); call(async () => "hello"); // Operation call({ *[Symbol.iterator]() { return "hello" } } ); call(function*() { return "hello" }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
resolve #798
Approach
This adds the following variations
However, it does not add the variation for constant values because they could include arrays and strings which are themselves iterable and so difficult to tell if they are an Operation or not.